Skip to content

Add GitCommit and Commit(-like) changes #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LecrisUT wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add GitCommit and Commit(-like) changes #921

LecrisUT wants to merge 5 commits into from
+3,455 −0

Conversation

@LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Apr 24, 2025 •
edited
Loading

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.
  • Update or write new documentation in packit/packit.dev.

Fixes

Related to

Merge before/after

RELEASE NOTES BEGIN

New abstract types for holding a GitCommit and its changes.

RELEASE NOTES END

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Apr 24, 2025

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/845135d2118e462cb367dc192e4c071e

✔️ pre-commit SUCCESS in 3m 40s
✔️ ogr-tests-pip-deps SUCCESS in 17m 31s

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Apr 24, 2025

Ok, basic functionality is in. Should we refine the API here, or do that in a follow-up addressing other suggestions like #924. There is definitely some duplication of the API now, but I will leave it at that for now.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Apr 24, 2025

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c4b44aa78d714f00b350c9f9bbd98074

✔️ pre-commit SUCCESS in 3m 47s
✔️ ogr-tests-pip-deps SUCCESS in 18m 00s

@LecrisUT LecrisUT force-pushed the feat/get_changes branch from 9a67970 to f87861b Compare May 23, 2025 08:36
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented May 23, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/e2c280bcb2ca4f2d884c8b3bd19e1560

❌ pre-commit FAILURE in 3m 52s
✔️ ogr-tests-pip-deps SUCCESS in 18m 11s

@LecrisUT LecrisUT mentioned this pull request May 23, 2025
Draft
4 tasks
lbarcziova
lbarcziova reviewed May 26, 2025
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for the contribution, looks really good!

Since the implementation is only for GitHub now, can you please update COMPATIBILITY.md accordingly?

@LecrisUT LecrisUT force-pushed the feat/get_changes branch from f87861b to fccfd71 Compare May 26, 2025 08:17
@LecrisUT
Copy link
Contributor Author

LecrisUT commented May 26, 2025

Since the implementation is only for GitHub now, can you please update COMPATIBILITY.md accordingly?

Yeah, would want to nail down more what we want to do with this interface before implementing in the other services. E.g. pull_request.changes.patch duplicates pul_request_.patch.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented May 26, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0c33807f846a488286c13740bcfeedeb

❌ pre-commit FAILURE in 3m 12s
✔️ ogr-tests-pip-deps SUCCESS in 18m 05s

@lbarcziova
Copy link
Member

lbarcziova commented May 26, 2025

@LecrisUT I see, we could have the functionality only in the new class while still preserving the old interface (e.g. pull_request.patch would call the new method) to maintain backward compatibility. But it would require some additional followup work. @mfocko do you want to have a look?

mfocko
mfocko reviewed May 28, 2025
View reviewed changes
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented May 28, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/10f0cdaf45704a09bcfaf37dfbe8abda

❌ pre-commit FAILURE in 2m 58s
✔️ ogr-tests-pip-deps SUCCESS in 18m 06s

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 2, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/fafc0b3da3e340e68b03c4f130636a17

❌ pre-commit FAILURE in 2m 57s
❌ ogr-tests-pip-deps FAILURE in 18m 19s

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 2, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/3378c5216ced48979fa491b66ae12da2

❌ pre-commit FAILURE in 2m 57s
❌ ogr-tests-pip-deps FAILURE in 18m 22s

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 2, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d9e5e4fe246b42749d668bdbf76ba7a3

❌ pre-commit FAILURE in 2m 56s
✔️ ogr-tests-pip-deps SUCCESS in 18m 16s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfocko mfocko mfocko left review comments

@betulependule betulependule betulependule left review comments

@lbarcziova lbarcziova lbarcziova left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Packit Kanban Board
Status: new

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LecrisUT @lbarcziova @mfocko @betulependule